sieni
/
linux
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

regulator: pca9450: Correct probed name for PCA9452 

An incorrect device name was logged for PCA9452 because the dev_info()
ternary omitted PCA9452 and fell through to "pca9450bc". Introduce a
type_name and set it per device type so the probed message matches the
actual PMIC. While here, make the PCA9451A case explicit.

No functional changes.

Fixes: 017b76fb8e ("regulator: pca9450: Add PMIC pca9452 support")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Link: https://patch.msgid.link/20260310-pca9450-irq-v1-2-36adf52c2c55@nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Peng Fan 2026-03-10 12:25:53 +08:00 committed by Mark Brown
parent 5d0efaf47e
commit 21b3fb7dc1
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/regulator/pca9450-regulator.c
View File

@ -1293,6 +1293,7 @@ static int pca9450_i2c_probe(struct i2c_client *i2c)
struct regulator_dev *ldo5; struct regulator_dev *ldo5;
struct pca9450 *pca9450; struct pca9450 *pca9450;
unsigned int device_id, i; unsigned int device_id, i;
const char *type_name;
int ret; int ret;
pca9450 = devm_kzalloc(&i2c->dev, sizeof(struct pca9450), GFP_KERNEL); pca9450 = devm_kzalloc(&i2c->dev, sizeof(struct pca9450), GFP_KERNEL);
@ -1303,15 +1304,22 @@ static int pca9450_i2c_probe(struct i2c_client *i2c)
case PCA9450_TYPE_PCA9450A: case PCA9450_TYPE_PCA9450A:
regulator_desc = pca9450a_regulators; regulator_desc = pca9450a_regulators;
pca9450->rcnt = ARRAY_SIZE(pca9450a_regulators); pca9450->rcnt = ARRAY_SIZE(pca9450a_regulators);
type_name = "pca9450a";
break; break;
case PCA9450_TYPE_PCA9450BC: case PCA9450_TYPE_PCA9450BC:
regulator_desc = pca9450bc_regulators; regulator_desc = pca9450bc_regulators;
pca9450->rcnt = ARRAY_SIZE(pca9450bc_regulators); pca9450->rcnt = ARRAY_SIZE(pca9450bc_regulators);
type_name = "pca9450bc";
break; break;
case PCA9450_TYPE_PCA9451A: case PCA9450_TYPE_PCA9451A:
regulator_desc = pca9451a_regulators;
pca9450->rcnt = ARRAY_SIZE(pca9451a_regulators);
type_name = "pca9451a";
break;
case PCA9450_TYPE_PCA9452: case PCA9450_TYPE_PCA9452:
regulator_desc = pca9451a_regulators; regulator_desc = pca9451a_regulators;
pca9450->rcnt = ARRAY_SIZE(pca9451a_regulators); pca9450->rcnt = ARRAY_SIZE(pca9451a_regulators);
type_name = "pca9452";
break; break;
default: default:
dev_err(&i2c->dev, "Unknown device type"); dev_err(&i2c->dev, "Unknown device type");
@ -1413,9 +1421,7 @@ static int pca9450_i2c_probe(struct i2c_client *i2c)
pca9450_i2c_restart_handler, pca9450)) pca9450_i2c_restart_handler, pca9450))
dev_warn(&i2c->dev, "Failed to register restart handler\n"); dev_warn(&i2c->dev, "Failed to register restart handler\n");
dev_info(&i2c->dev, "%s probed.\n", dev_info(&i2c->dev, "%s probed.\n", type_name);
type == PCA9450_TYPE_PCA9450A ? "pca9450a" :
(type == PCA9450_TYPE_PCA9451A ? "pca9451a" : "pca9450bc"));
return 0; return 0;
} }