tools/bootconfig: fix fd leak in load_xbc_file() on fstat failure

If fstat() fails after open() succeeds, the function returns without
closing the file descriptor. Also preserve errno across close(), since
close() may overwrite it before the error is returned.

Link: https://lore.kernel.org/all/20260318155847.78065-3-objecting@objecting.org/

Fixes: 950313ebf7 ("tools: bootconfig: Add bootconfig command")
Signed-off-by: Josh Law <objecting@objecting.org>
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
This commit is contained in:
Josh Law 2026-03-19 08:43:06 +09:00 committed by Masami Hiramatsu (Google)
parent bb288d7d86
commit 3b2c2ab4ce
1 changed files with 5 additions and 2 deletions

View File

@ -162,8 +162,11 @@ static int load_xbc_file(const char *path, char **buf)
if (fd < 0)
return -errno;
ret = fstat(fd, &stat);
if (ret < 0)
return -errno;
if (ret < 0) {
ret = -errno;
close(fd);
return ret;
}
ret = load_xbc_fd(fd, buf, stat.st_size);