2df6162785
So far the driver populated the struct can_priv::do_set_bittiming() and
struct can_priv::fd::do_set_data_bittiming() callbacks.
Before bringing up the interface, user space has to configure the bitrates.
With these callbacks the configuration is directly forwarded into the CAN
hardware. Then the interface can be brought up.
An ifdown-ifup cycle (without changing the bit rates) doesn't re-configure
the bitrates in the CAN hardware. This leads to a problem with the
CANable-2.5 [1] firmware, which resets the configured bit rates during
ifdown.
To fix the problem remove both bit timing callbacks and always configure
the bitrates in the struct net_device_ops::ndo_open() callback.
[1] https://github.com/Elmue/CANable-2.5-firmware-Slcan-and-Candlelight
Cc: stable@vger.kernel.org
Fixes:
|
||
|---|---|---|
| .. | ||
| etas_es58x | ||
| kvaser_usb | ||
| peak_usb | ||
| Kconfig | ||
| Makefile | ||
| ems_usb.c | ||
| esd_usb.c | ||
| f81604.c | ||
| gs_usb.c | ||
| mcba_usb.c | ||
| nct6694_canfd.c | ||
| ucan.c | ||
| usb_8dev.c | ||