Jakub Kicinski 93e71edfd9 devlink: keep the instance mutex alive until references are gone ... The reference needs to keep the instance memory around, but also the instance lock must remain valid. Users will take the lock, check registration status and release the lock. mutex_destroy() etc. belong in the same place as the freeing of the memory. Unfortunately lockdep_unregister_key() sleeps so we need to switch the an rcu_work. Note that the problem is a bit hard to repro, because devlink_pernet_pre_exit() iterates over registered instances. AFAIU the instances must get devlink_free()d concurrently with the namespace getting deleted for the problem to occur. Reported-by: syzbot+d94d214ea473e218fc89@syzkaller.appspotmail.com Reported-by: syzbot+9f0dd863b87113935acf@syzkaller.appspotmail.com Fixes: 9053637e0d ("devlink: remove the registration guarantee of references") Reviewed-by: Jiri Pirko <jiri@nvidia.com> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> Link: https://lore.kernel.org/r/20230111042908.988199-1-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2023-01-11 20:49:32 -08:00
..
Makefile	devlink: split out netlink code	2023-01-05 22:13:39 -08:00
core.c	devlink: keep the instance mutex alive until references are gone	2023-01-11 20:49:32 -08:00
devl_internal.h	devlink: keep the instance mutex alive until references are gone	2023-01-11 20:49:32 -08:00
leftover.c	devlink: allow registering parameters after the instance	2023-01-06 12:56:19 +00:00
netlink.c	devlink: always check if the devlink instance is registered	2023-01-06 12:56:19 +00:00