sieni
/
linux
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
linux/drivers/net
History
Yue Haibing b3dc6e8003 ipvlan: Dont Use skb->sk in ipvlan_process_v{4,6}_outbound 
Raw packet from PF_PACKET socket ontop of an IPv6-backed ipvlan device will
hit WARN_ON_ONCE() in sk_mc_loop() through sch_direct_xmit() path.

WARNING: CPU: 2 PID: 0 at net/core/sock.c:775 sk_mc_loop+0x2d/0x70
Modules linked in: sch_netem ipvlan rfkill cirrus drm_shmem_helper sg drm_kms_helper
CPU: 2 PID: 0 Comm: swapper/2 Kdump: loaded Not tainted 6.9.0+ #279
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.15.0-1 04/01/2014
RIP: 0010:sk_mc_loop+0x2d/0x70
Code: fa 0f 1f 44 00 00 65 0f b7 15 f7 96 a3 4f 31 c0 66 85 d2 75 26 48 85 ff 74 1c
RSP: 0018:ffffa9584015cd78 EFLAGS: 00010212
RAX: 0000000000000011 RBX: ffff91e585793e00 RCX: 0000000002c6a001
RDX: 0000000000000000 RSI: 0000000000000040 RDI: ffff91e589c0f000
RBP: ffff91e5855bd100 R08: 0000000000000000 R09: 3d00545216f43d00
R10: ffff91e584fdcc50 R11: 00000060dd8616f4 R12: ffff91e58132d000
R13: ffff91e584fdcc68 R14: ffff91e5869ce800 R15: ffff91e589c0f000
FS:  0000000000000000(0000) GS:ffff91e898100000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f788f7c44c0 CR3: 0000000008e1a000 CR4: 00000000000006f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<IRQ>
 ? __warn (kernel/panic.c:693)
 ? sk_mc_loop (net/core/sock.c:760)
 ? report_bug (lib/bug.c:201 lib/bug.c:219)
 ? handle_bug (arch/x86/kernel/traps.c:239)
 ? exc_invalid_op (arch/x86/kernel/traps.c:260 (discriminator 1))
 ? asm_exc_invalid_op (./arch/x86/include/asm/idtentry.h:621)
 ? sk_mc_loop (net/core/sock.c:760)
 ip6_finish_output2 (net/ipv6/ip6_output.c:83 (discriminator 1))
 ? nf_hook_slow (net/netfilter/core.c:626)
 ip6_finish_output (net/ipv6/ip6_output.c:222)
 ? __pfx_ip6_finish_output (net/ipv6/ip6_output.c:215)
 ipvlan_xmit_mode_l3 (drivers/net/ipvlan/ipvlan_core.c:602) ipvlan
 ipvlan_start_xmit (drivers/net/ipvlan/ipvlan_main.c:226) ipvlan
 dev_hard_start_xmit (net/core/dev.c:3594)
 sch_direct_xmit (net/sched/sch_generic.c:343)
 __qdisc_run (net/sched/sch_generic.c:416)
 net_tx_action (net/core/dev.c:5286)
 handle_softirqs (kernel/softirq.c:555)
 __irq_exit_rcu (kernel/softirq.c:589)
 sysvec_apic_timer_interrupt (arch/x86/kernel/apic/apic.c:1043)

The warning triggers as this:
packet_sendmsg
   packet_snd //skb->sk is packet sk
      __dev_queue_xmit
         __dev_xmit_skb //q->enqueue is not NULL
             __qdisc_run
               sch_direct_xmit
                 dev_hard_start_xmit
                   ipvlan_start_xmit
                      ipvlan_xmit_mode_l3 //l3 mode
                        ipvlan_process_outbound //vepa flag
                          ipvlan_process_v6_outbound
                            ip6_local_out
                                __ip6_finish_output
                                  ip6_finish_output2 //multicast packet
                                    sk_mc_loop //sk->sk_family is AF_PACKET

Call ip{6}_local_out() with NULL sk in ipvlan as other tunnels to fix this.

Fixes: 2ad7bf3638 ("ipvlan: Initial check-in of the IPVLAN driver.")
Suggested-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20240529095633.613103-1-yuehaibing@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
 		2024-05-30 12:05:52 +02:00
..
arcnet archnet: Convert from tasklet to BH workqueue 2024-04-08 19:44:09 -07:00
bonding bonding: fix oops during rmmod 2024-05-16 19:33:07 -07:00
caif net: caif: virtio: drop owner assignment 2024-05-22 08:31:17 -04:00
can net: annotate writes on dev->mtu from ndo_change_mtu() 2024-05-07 16:19:14 -07:00
dsa net: dsa: microchip: fix RGMII error in KSZ DSA driver 2024-05-29 18:44:36 -07:00
ethernet net: ena: Fix redundant device NUMA node override 2024-05-29 19:01:34 -07:00
fddi net: handle HAS_IOPORT dependencies 2024-04-08 11:56:56 +01:00
fjes tracing/treewide: Remove second parameter of __assign_str() 2024-05-22 20:14:47 -04:00
hamradio net: handle HAS_IOPORT dependencies 2024-04-08 11:56:56 +01:00
hippi
…
hyperv tracing/treewide: Remove second parameter of __assign_str() 2024-05-22 20:14:47 -04:00
ieee802154
…
ipa net: ipa: allocate dummy net_device dynamically 2024-04-24 12:00:16 +01:00
ipvlan ipvlan: Dont Use skb->sk in ipvlan_process_v{4,6}_outbound 2024-05-30 12:05:52 +02:00
mctp
…
mdio net: mdio-gpio: Use device_is_compatible() 2024-04-08 11:05:09 +01:00
netdevsim netdevsim: add NAPI support 2024-05-08 18:59:47 -07:00
pcs net: pcs: lynx: no need to read LPA in lynx_pcs_get_state_2500basex() 2024-05-13 16:37:18 -07:00
phy net: micrel: Fix lan8841_config_intr after getting out of sleep mode 2024-05-27 16:58:39 -07:00
plip
…
ppp rtnetlink: allow rtnl_fill_link_netnsid() to run under RCU protection 2024-05-07 11:14:50 +02:00
pse-pd net: pse-pd: Kconfig: Add missing Regulator API dependency 2024-04-24 20:14:16 -07:00
slip net: annotate writes on dev->mtu from ndo_change_mtu() 2024-05-07 16:19:14 -07:00
team net: annotate writes on dev->mtu from ndo_change_mtu() 2024-05-07 16:19:14 -07:00
thunderbolt
…
usb net: usb: smsc95xx: fix changing LED_SEL bit value updated from EEPROM 2024-05-27 12:48:23 +02:00
vmxnet3 net: annotate writes on dev->mtu from ndo_change_mtu() 2024-05-07 16:19:14 -07:00
vxlan net: annotate writes on dev->mtu from ndo_change_mtu() 2024-05-07 16:19:14 -07:00
wan net: wan: fsl_qmc_hdlc: Convert to platform remove callback returning void 2024-04-10 19:35:50 -07:00
wireguard
…
wireless tracing: Remove second argument of __assign_str() 2024-05-23 12:28:01 -07:00
wwan net: wwan: t7xx: Un-embed dummy device 2024-04-25 19:32:31 -07:00
xen-netback net: annotate writes on dev->mtu from ndo_change_mtu() 2024-05-07 16:19:14 -07:00
Kconfig net: netdevsim: select PAGE_POOL in Kconfig 2024-04-17 18:25:30 -07:00
LICENSE.SRC
…
Makefile net: Always descend into dsa/ folder with CONFIG_NET_DSA enabled 2024-05-20 11:04:29 +01:00
Space.c
…
amt.c
…
bareudp.c
…
dummy.c
…
eql.c
…
geneve.c net: annotate writes on dev->mtu from ndo_change_mtu() 2024-05-07 16:19:14 -07:00
gtp.c gtp: identify tunnel via GTP device + GTP version + TEID + family 2024-05-07 01:36:02 +02:00
ifb.c
…
loopback.c net: loopback: Do not allocate lstats explicitly 2024-04-30 19:01:58 -07:00
macsec.c net: annotate writes on dev->mtu from ndo_change_mtu() 2024-05-07 16:19:14 -07:00
macvlan.c net: annotate writes on dev->mtu from ndo_change_mtu() 2024-05-07 16:19:14 -07:00
macvtap.c
…
mdio.c
…
mhi_net.c
…
mii.c
…
net_failover.c net: annotate writes on dev->mtu from ndo_change_mtu() 2024-05-07 16:19:14 -07:00
netconsole.c
…
netkit.c netkit: Fix pkt_type override upon netkit pass verdict 2024-05-25 10:48:57 -07:00
nlmon.c
…
ntb_netdev.c net: annotate writes on dev->mtu from ndo_change_mtu() 2024-05-07 16:19:14 -07:00
pfcp.c pfcp: avoid copy warning by simplifing code 2024-04-08 11:46:41 +01:00
rionet.c
…
sb1000.c
…
sungem_phy.c
…
tap.c net: extend ubuf_info callback to ops structure 2024-04-22 16:21:35 -07:00
tun.c for-6.10/io_uring-20240511 2024-05-13 12:48:06 -07:00
veth.c Revert "net: mirror skb frag ref/unref helpers" 2024-05-03 16:05:53 -07:00
virtio_net.c virtio: features, fixes, cleanups 2024-05-23 12:04:36 -07:00
vrf.c inet: introduce dst_rtable() helper 2024-04-30 18:32:38 -07:00
vsockmon.c net: annotate writes on dev->mtu from ndo_change_mtu() 2024-05-07 16:19:14 -07:00
xen-netfront.c net: annotate writes on dev->mtu from ndo_change_mtu() 2024-05-07 16:19:14 -07:00