Moshe Shemesh da2e552b46 net/mlx5: Fix command stats access after free ... Command may fail while driver is reloading and can't accept FW commands till command interface is reinitialized. Such command failure is being logged to command stats. This results in NULL pointer access as command stats structure is being freed and reallocated during mlx5 devlink reload (see kernel log below). Fix it by making command stats statically allocated on driver probe. Kernel log: [ 2394.808802] BUG: unable to handle kernel paging request at 000000000002a9c0 [ 2394.810610] PGD 0 P4D 0 [ 2394.811811] Oops: 0002 [#1] SMP NOPTI ... [ 2394.815482] RIP: 0010:native_queued_spin_lock_slowpath+0x183/0x1d0 ... [ 2394.829505] Call Trace: [ 2394.830667] _raw_spin_lock_irq+0x23/0x26 [ 2394.831858] cmd_status_err+0x55/0x110 [mlx5_core] [ 2394.833020] mlx5_access_reg+0xe7/0x150 [mlx5_core] [ 2394.834175] mlx5_query_port_ptys+0x78/0xa0 [mlx5_core] [ 2394.835337] mlx5e_ethtool_get_link_ksettings+0x74/0x590 [mlx5_core] [ 2394.836454] ? kmem_cache_alloc_trace+0x140/0x1c0 [ 2394.837562] __rh_call_get_link_ksettings+0x33/0x100 [ 2394.838663] ? __rtnl_unlock+0x25/0x50 [ 2394.839755] __ethtool_get_link_ksettings+0x72/0x150 [ 2394.840862] duplex_show+0x6e/0xc0 [ 2394.841963] dev_attr_show+0x1c/0x40 [ 2394.843048] sysfs_kf_seq_show+0x9b/0x100 [ 2394.844123] seq_read+0x153/0x410 [ 2394.845187] vfs_read+0x91/0x140 [ 2394.846226] ksys_read+0x4f/0xb0 [ 2394.847234] do_syscall_64+0x5b/0x1a0 [ 2394.848228] entry_SYSCALL_64_after_hwframe+0x65/0xca Fixes: 34f46ae0d4 ("net/mlx5: Add command failures data to debugfs") Signed-off-by: Moshe Shemesh <moshe@nvidia.com> Reviewed-by: Shay Drory <shayd@nvidia.com> Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>		2023-01-09 22:08:34 -08:00
..
acpi	ACPI: video: Allow GPU drivers to report no panels	2022-12-22 17:26:41 +01:00
asm-generic	arch: fix broken BuildID for arm64 and riscv	2022-12-30 17:21:51 +09:00
clocksource	Updates for timers, timekeeping and drivers:	2022-12-12 12:52:02 -08:00
crypto	crypto: acomp - define max size for destination	2022-12-09 18:45:00 +08:00
drm	Some deferred-io and damage worker reworks revert and make a fb function	2022-12-09 11:53:52 +10:00
dt-bindings	remoteproc updates for v6.2	2022-12-21 09:37:14 -08:00
keys	…
kunit	kunit: add macro to allow conditionally exposing static symbols to tests	2022-12-12 14:13:48 -07:00
kvm	Merge branch kvm-arm64/pmu-unchained into kvmarm-master/next	2022-12-05 14:38:44 +00:00
linux	net/mlx5: Fix command stats access after free	2023-01-09 22:08:34 -08:00
math-emu	…
media	Merge tag 'br-v6.2i' of git://linuxtv.org/hverkuil/media_tree into media_stage	2022-12-07 17:58:47 +01:00
memory	…
misc	…
net	rxrpc: Tidy up abort generation infrastructure	2023-01-06 09:43:32 +00:00
pcmcia	…
ras	…
rdma	RDMA: Extend RDMA kernel verbs ABI to support flush	2022-12-09 19:36:01 -04:00
rv	…
scsi	SCSI misc on 20221222	2022-12-22 11:22:31 -08:00
soc	Networking changes for 6.2.	2022-12-13 15:47:48 -08:00
sound	ALSA: hda/hdmi: fix stream-id config keep-alive for rt suspend	2022-12-09 12:06:15 +01:00
target	…
trace	rxrpc: Move client call connection to the I/O thread	2023-01-06 09:43:33 +00:00
uapi	Including fixes from bpf, wifi, and netfilter.	2023-01-05 12:40:50 -08:00
ufs	…
vdso	…
video	fbdev: omapfb: connector-analog-tv: remove support for platform data	2022-12-14 20:01:49 +01:00
xen	xen: fix xen.h build for CONFIG_XEN_PVH=y	2022-12-05 12:59:49 +01:00