Joe Damato 08062af0a5 net: napi: Prevent overflow of napi_defer_hard_irqs ... In commit 6f8b12d661 ("net: napi: add hard irqs deferral feature") napi_defer_irqs was added to net_device and napi_defer_irqs_count was added to napi_struct, both as type int. This value never goes below zero, so there is not reason for it to be a signed int. Change the type for both from int to u32, and add an overflow check to sysfs to limit the value to S32_MAX. The limit of S32_MAX was chosen because the practical limit before this patch was S32_MAX (anything larger was an overflow) and thus there are no behavioral changes introduced. If the extra bit is needed in the future, the limit can be raised. Before this patch: $ sudo bash -c 'echo 2147483649 > /sys/class/net/eth4/napi_defer_hard_irqs' $ cat /sys/class/net/eth4/napi_defer_hard_irqs -2147483647 After this patch: $ sudo bash -c 'echo 2147483649 > /sys/class/net/eth4/napi_defer_hard_irqs' bash: line 0: echo: write error: Numerical result out of range Similarly, /sys/class/net/XXXXX/tx_queue_len is defined as unsigned: include/linux/netdevice.h: unsigned int tx_queue_len; And has an overflow check: dev_change_tx_queue_len(..., unsigned long new_len): if (new_len != (unsigned int)new_len) return -ERANGE; Suggested-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Joe Damato <jdamato@fastly.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Link: https://patch.msgid.link/20240904153431.307932-1-jdamato@fastly.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2024-09-05 18:42:56 -07:00
..
acpi	ACPI: video: Add Dell UART backlight controller detection	2024-08-19 15:58:35 +02:00
asm-generic	runtime constants: deal with old decrepit linkers	2024-08-03 08:38:45 -07:00
clocksource	…
crypto	…
drm	drm/buddy: Add start address support to trim function	2024-08-07 18:19:00 -04:00
dt-bindings	I3C for 6.11	2024-07-27 10:53:06 -07:00
keys	…
kunit	…
kvm	…
linux	net: napi: Prevent overflow of napi_defer_hard_irqs	2024-09-05 18:42:56 -07:00
math-emu	…
media	…
memory	…
misc	…
net	wireless-next patches for v6.12	2024-09-04 17:20:14 -07:00
pcmcia	…
ras	…
rdma	…
rv	…
scsi	scsi: core: Fix the return value of scsi_logical_block_count()	2024-08-16 21:02:06 -04:00
soc	net: mscc: ocelot: treat 802.1ad tagged traffic as 802.1Q-untagged	2024-08-16 09:59:32 +01:00
sound	ASoC: Fixes for v6.11	2024-08-09 09:58:07 +02:00
target	…
trace	rpcrdma: Trace connection registration and unregistration	2024-08-19 11:50:41 -04:00
uapi	ipv4: Fix user space build failure due to header change	2024-09-04 16:40:33 -07:00
ufs	scsi: ufs: core: Add a quirk for handling broken LSDBS field in controller capabilities register	2024-08-16 21:09:17 -04:00
vdso	Random number generator updates for Linux 6.11-rc1.	2024-07-24 10:29:50 -07:00
video	…
xen	Driver core changes for 6.11-rc1	2024-07-25 10:42:22 -07:00